beautifier/js-beautify

HTML option "wrap-attributes": "preserve" does not preserve line break before closing angle bracket

Open

#1,707 创建于 2019年9月10日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)JavaScript (8,342 star) (1,460 fork)batch import
good first issuelanguage: htmltype: bug

描述

If you use "wrap-attributes": "force-expand-multiline", you get:

<tag
    attr1="val1"
    attr2="val2"
>content</tag>

The line break before the closing angle bracket is forced with this option.

Now, when you set "wrap-attributes": "preserve", I would expect this formatting to be preserved. However, you get:

<tag
    attr1="val1"
    attr2="val2">content</tag>

Please fix "preserved" or add a new option for keeping the line break before the closing angle bracket.

贡献者指南

技术栈
javascripthtmlcss
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptjs beautify internalsHTML parsing
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the HTML beautifier code in js beautify, likely in `js/lib/beautify html.js`, to understand how 'wrap attributes' options are handled. Look for the logic that distinguishes 'force expand multiline' from 'preserve' regarding line breaks before closing angle brackets. Consider adding a new option or modifying the preserve behavior to retain the line break. Check existing tests in the `test` directory for related test cases.
HTML option "wrap-attributes": "preserve" does not preserve line break before closing angle bracket · beautifier/js-beautify#1707 | Good First Issue