balderdashy/sails

How to handle a route with a dot in route param

Open

#6,954 创建于 2020年2月25日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)JavaScript (22,778 star) (1,953 fork)batch import
does this answer your question?help wanted

描述

Node version: 10.19.0 Sails version (sails): 1.2.3

Hi,

I have a controller which serves an image. I am trying to get this route to work

/content/26/image.png

It responses 404 but work with

/content/26/image.png/

I got it to work with a custom inline route ( fn: async function (req, res)) but I want access control for this route.

Many thanks in advance and kindest regards

贡献者指南

技术栈
javascriptnodejs
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.jsSails framework
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate how Sails' router handles dots in route parameters by examining the source code in `lib/router/` and related configuration. Check if there is an existing option to allow dots in param values, and consider submitting a fix that updates the route matching regex or adds a flag. Review comments in the issue for any maintainer suggestions.
How to handle a route with a dot in route param · balderdashy/sails#6954 | Good First Issue