awslabs/benchmark-ai

[Executor] Dangling resources on failed kubectl apply

开放

#943 创建于 2019年10月14日

 (0 条评论) (0 个反应) (0 位负责人)Python (6 个派生)auto 404
buggood first issueservice:executor

仓库指标

星标
 (19 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

The executor creates the kubernetes resources by executing a kubectl apply against a generated kubernetes resource file. Sometimes, these files can contain multiple resource definitions (Jobs, Pods, Services, Roles, etc.). This means that, while the command itself can fail (exit with non-zero), some of the (valid) kuberenetes resources would still be created.

We should issue a kubectl delete in case there is a failure. To ensure we don't leave any dangling resources in case of any failure.

贡献者指南