aws/aws-cdk

(cli): Support notification-arns in cdk import

Open

#23,548 创建于 2023年1月3日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (3,530 fork)batch import
effort/smallfeature-requestgood first issuep2package/tools

仓库指标

Star
 (10,710 star)
PR 合并指标
 (平均合并 14天 11小时) (30 天内合并 68 个 PR)

描述

Describe the feature

When using the cdk import command (https://github.com/aws/aws-cdk-rfcs/issues/52), there doesn't appear to be a way to pass the --notification-arns flag as you can do in a normal deployment. Since an import operation creates a cloudformation change set and --notification-arns is already a valid flag on the cdk deploy command, it's reasonable to expect that this paramer could be passed for cdk import as well.

Use Case

When updating Cloudformation stacks, processes that trigger off Cloudformation notifications and need a way to be able to pass the SNS topic so they can react to import operations triggered via CDK.

Proposed Solution

Since --notification-arns is already present and supported on cdk deploy, this should be implemented the same way to that someone who is used to using that flag on the deploy command can apply it to cdk import as well. This would be an optional parameter so it shouldn't negatively impact any existing workflows.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.59.0 and 1.186.1

Environment details (OS name and version, etc.)

N/A - New Feature Request

贡献者指南