avo-hq/avo

Make action forms better

Open

#2,670 创建于 2024年4月9日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Ruby (1,778 star) (308 fork)user submission
EnhancementHelp wantedJavascript

描述

Feature

  • Create a stimulus controller that disables the submit form until all required fields have content.
  • Associate fields with errors coming from the backend and render errors before calling the handle method (as suggested by Paul Bob on Discord).

Current workarounds

def handle...
  if some_field.blank?
    error "Something happened"
    keep_modal_open
    return
  end
end

Additional context

https://discord.com/channels/740892036978442260/1226288821780484137

贡献者指南

技术栈
rubyjavascript
领域
full stack
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Ruby on Rails basicsStimulus basicsHTML forms
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the existing action forms implementation in the Avo codebase, likely in files related to the Actions controller and Stimulus controllers (e.g., app/controllers/avo/actions controller.rb and app/javascript/controllers/). Review the Discord discussion linked for additional context on desired behavior. Consider how to disable the submit button until required fields are filled using Stimulus, and how to display backend errors before the handle method executes.