avajs/ava

Make t.fail() accept an object

Open

#2,615 创建于 2020年11月25日

在 GitHub 查看
 (5 评论) (1 反应) (0 负责人)JavaScript (20,600 star) (1,408 fork)batch import
enhancementhelp wantedscope:assertions

描述

It seems like the only problem with #1094 is providing detailed error output when a custom assertion fails. Everything else is straightforward. What if t.fail() could accept an object to use for creating an AssertionError? The fields could be message, actual, expected, and format that will specifying which formatting function to use for setting the values field on the error object. Could also add an optional assertion field for a custom assertion name.

Would this be compatible with #2435?

If there's interest, I can submit a PR for this.

贡献者指南

技术栈
javascriptnodejs
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Knowledge of AVAJavaScriptNode.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the current implementation of t.fail() in AVA's source code. Review issues #1094 and #2435 for context on desired behavior. Look at how AssertionError is created in the codebase. Consider adding a new function or modifying t.fail to accept an object with fields like message, actual, expected, format, and assertion. Ensure compatibility with existing error formatting.
Make t.fail() accept an object · avajs/ava#2615 | Good First Issue