avajs/ava

Feature Request: A way to mark a test 'skipped' after it starts

Open

#2,010 创建于 2019年1月9日

在 GitHub 查看
 (12 评论) (2 反应) (0 负责人)JavaScript (20,600 star) (1,408 fork)batch import
enhancementhelp wantedscope:assertions

描述

Description

I'm using ava to control selenium-webdriver for tests run in Firefox and Chrome. It cannot be known synchronously if the browser can be run. An example flow could be:

test('somepage.html', async t => {
  try {
    await loadPage('somepage.html');
  } catch (error) {
    t.skip();
    return;
  }
  // testing against the page here
});

In this example loadPage() will reject if the browser cannot be started, otherwise it will resolve. The goal is that the test will report skipped if the browser cannot be run.

It would probably be good if t.skip() threw an exception if any assertions have already run for that test.

Environment

Node.js v10.14.2
linux 4.19.8-200.fc28.x86_64
ava 1.0.1
npm 6.4.1

贡献者指南

技术栈
javascriptnodejs
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptNode.jsbasic understanding of test runner lifecycle
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests adding a programmatic skip method that can be called after a test has started. To implement, one should first explore the existing test API in ava, particularly the test object and how skip is currently handled (likely via a flag before test execution). The body suggests that t.skip() should throw an error if assertions have already run, so a mechanism to track whether any assertions have been made is needed. Comments on the issue may contain further discussion on implementation approaches. Key files to examine include the test execution code and the test object implementation.