avajs/ava

Log test duration for serial tests only

Open

#1,668 创建于 2018年1月29日

在 GitHub 查看
 (20 评论) (0 反应) (0 负责人)JavaScript (20,600 star) (1,408 fork)batch import
enhancementhelp wantedscope:internalsscope:reporters

描述

I'm thinking of revisiting #971, but with a twist.

Reporting test duration when tests run concurrently can be misleading, since slow, synchronous code in one test also slows down another. This is why I've been hesitant of exposing the duration numbers in the TAP reporter.

Oddly though we do show durations in the verbose reporter! This has survived all the way from #30.

I wonder if we should only show durations when --serial is used. This way the numbers will be more accurate and users will be less tempted to fix one "slow" test while the problem is another. We can then also include it in the TAP output.

贡献者指南

技术栈
javascriptnodejs
领域
testingcliperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of AVAFamiliarity with reporter implementationUnderstanding of concurrent vs serial execution
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Review the verbose reporter code (likely in lib/reporter/verbose.js or similar) to identify where durations are printed. Examine the CLI option parsing for serial (maybe in cli.js). Understand the relationship between concurrent and serial test execution as discussed in issues #971 and #30. Implement a conditional to log durations only when serial is active.