avajs/ava

Diffs for arrays of strings can be pretty confusing

Open

#1,521 创建于 2017年9月16日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (20,600 star) (1,408 fork)batch import
bughelp wantedscope:assertionsscope:reporters

描述

If you do t.deepEqual (and I think also t.is) on two arrays containing strings. If there are a large amount of strings and they only differ slightly the output is very confusing. It appears that as soon as a new entry in an array has shifted the items after it across, AVA text diffs every single entry against the same index in the original array.

e.g: An array with 219 strings that has had 6 additions and 1 deletion: AVA diff: https://travis-ci.org/lukechilds/window/jobs/266859856 GitHub diff: https://github.com/lukechilds/window/pull/7/commits/6ecbade39561cf705ddc2833cbc3b93e2abfb223

贡献者指南

技术栈
javascript
领域
testing
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptBasic understanding of AVAFamiliarity with array diff algorithms
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Review the current diff output logic for arrays in AVA's assertion code, likely in files like lib/assert.js or lib/format diff.js. Analyze the provided examples to understand the alignment issue. Consider implementing a smarter diff that accounts for insertions/deletions rather than index based comparison.