atom/github

Click Staged/Unstaged Changes header to select all files

Open

#1,800 创建于 2018年11月15日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (1,069 star) (469 fork)batch import
good first issuepapercut

描述

In at least couple of user interviews I participated in, the user tried to select all files by clicking the header. This behavior would be consistent with what we have in the ChangedFileItem where clicking a hunk header highlights all the changed lines in the hunk

贡献者指南

技术栈
javascript
领域
frontenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with Atom package developmentBasic knowledge of Git staging UI
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the Click handling in the ChangedFileItem component (likely in packages/github/lib/views/ changed file item.js) to see how hunk header clicks select all lines. Then apply similar logic to the Staged/Unstaged Changes header components (e.g., staged changes view and unstaged changes view). The issue mentions that users expect clicking the header to select all files, so look at the header's click event and implement a handler that checks all file checkboxes within that section.
Click Staged/Unstaged Changes header to select all files · atom/github#1800 | Good First Issue