atom/github

Inconsistency in symlink path

Open

#1,761 创建于 2018年10月25日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (1,069 star) (469 fork)batch import
good first issue

描述

Some symlink diffs show the symlink destination path as a relative path, others as an absolute path. It'd be nice to be consistent.

as per @kuychaco:

Here's a tiny inconsistency in how we present the symlink path (relative vs. absolute) -- no big deal really, just wanted to point it out. We don't have to resolve it for this PR. Could make a good first issue for someone in the community if we don't get around to it before merge.

symlink-path-inconsistency

Originally reported by @kuychaco in https://github.com/atom/github/pull/1512#issuecomment-430437777.

贡献者指南

技术栈
javascript
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Atom plugin developmentsymlinks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue requires making symlink destination paths consistent (relative vs. absolute) in the diff view. Refer to the screenshot and the comment at https://github.com/atom/github/pull/1512#issuecomment 430437777. The fix likely involves locating the code that renders symlink paths in the Atom GitHub package, standardizing the format.