atom/github

Replace getDerivedStateFromProps with memoization

Open

#1,611 创建于 2018年7月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (1,069 star) (469 fork)batch import
code-cleanup :wrench:good first issue

描述

Where possible, it would be cleaner and less error-prone to replace components that implement static getDerivedStateFromProps() with PureComponents or memoize-one:

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of memoization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Search the codebase for components that implement the getDerivedStateFromProps lifecycle method. In each case, evaluate whether the derived state can be computed using memoization with memoize one or by converting to a PureComponent. Follow the guidance in the linked React blog post. Ensure test coverage for the affected components. Since the issue is from 2018, verify that the components still exist and the pattern is still applicable.