assisrafael/angular-input-masks

Match regex before applying mask

Open

#63 创建于 2015年3月15日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (970 star) (334 fork)batch import
enhancementhelp wanted

描述

Check if the current $modelValue matches the desired mask, instead of forcefully removing all the non matching characters first.

Example: if I have an input with <input type="text" ui-br-cep-mask ng-model="user.data.cep"> and user.data.cep is "00000-000" (this is the $modelValue) don't try to change the $viewValue of it, or the input will become truncated because of these lines:

var formatedValue = processed.result;
return formatedValue.trim().replace(/[^0-9]$/, '');

Before this line, it's saying 00000- and that's not valid. It may be a bug.

The input will be set to 00000 instead of 00000-000 because of this. The same goes to all other directives (CPF, CNPJ, Date, etc)

IMHO an UI library shouldn't dictate the format of the data that goes into the database, the library should fit the data you provide to it. I always keep the format in the database, and would never store a mobile as an int like 11999999999 into the database

贡献者指南

技术栈
javascripthtml
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Basic AngularJS knowledgeFamiliarity with input masks
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the source code of the ui br cep mask directive in the repository (likely in a file like 'br cep mask.js') to understand how the mask is currently applied. Look for the lines that forcefully remove non matching characters before checking the model value. Consider implementing a check that verifies if the current $modelValue matches the desired mask pattern before applying any modifications, similar to the approach suggested in the issue.