argotorg/solidity

Should private functions really clash ?

开放

#11,889 创建于 2021年9月3日

 (45 条评论) (6 个反应) (0 位负责人)C++ (6,109 个派生)batch import
bounty worthy :moneybag:help wantedlow effortlow impactnice to have

仓库指标

星标
 (25,634 个星标)
PR 合并指标
 (平均合并 8天 8小时) (30 天内合并 30 个 PR)

描述

Let consider the following code:

contract A {
    function __myPrivateFunction() private {
        // Does something usefull
    }
    
    function callA() public {
        __myPrivateFunction();
    }
}

contract B {
    function __myPrivateFunction() private {
        // Does something usefull
    }
    
    function callB() public {
        __myPrivateFunction();
    }
}

contract AB is A, B {}

What I am expecting

implementation of __myPrivateFunction are private, and they only make sense in the context of the contract that they are part of (A and B). They are not accessible from AB, so it is not like if a call from a function within AB wouldn't be resolvable.

IMO, this should compile, possibly with a warning, but not with an error.

What happens

I get an error:

TypeError: Derived contract must override function "__myPrivateFunction". Two or more base classes define function with same name and parameter types.

Question/Request

Is that behaviour wanted? needed? Whould it be possible to accept this kind of ghost-conflicts?

贡献者指南