apple/swift-nio

NIOLoopBound should get `unchecked` variants that are truly free in release mode

Open

#2,506 创建于 2023年8月17日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)Swift (8,453 star) (749 fork)batch import
good first issuekind/enhancement

描述

NIOLoopBound(Box) is super useful when adopting Sendable but the eventLoop.preconditionInEventLoop() checks everywhere are expensive and -- for repeated accesses -- unnecessary.

There should be unchecked variants of init, get and set value that do eventLoop.assertInEventLoop() instead. Together with @inlinable that should become completely free in release mode (and still check in debug).

Docs:

贡献者指南

技术栈
swift
领域
backendperformance
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Swift concurrencyNIOLoopBound APIassert vs precondition
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The implementation should add new initializers and methods to `NIOLoopBound` and `NIOLoopBoundBox` in the NIO module. The issue suggests using `assertInEventLoop` instead of `preconditionInEventLoop` in the unchecked variants, and marking them with `@inlinable` for release mode optimization. Contributors should review the existing implementation at the provided documentation links and consider any thread safety implications.