apache/superset

supersetCanCSV property naming could be better

Open

#24,290 创建于 2023年6月5日

在 GitHub 查看
 (12 评论) (1 反应) (0 负责人)TypeScript (72,837 star) (17,291 fork)batch import
good first issuerisk:breaking-change

描述

Description

Javascript code uses supersetCanCSV property to check wether user is allowed to download chart as csv, excel or image.

This is bit outdated, supersetCanDownload would be more informative?

贡献者指南

技术栈
typescriptreact
领域
frontenddeveloper experience
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with JavaScript/TypeScriptBasic knowledge of Apache Superset codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
Search the codebase for all occurrences of 'supersetCanCSV' and replace them with 'supersetCanDownload'. Ensure that all references in JavaScript/TypeScript files, tests, and documentation are updated. Confirm that the new naming is consistent with existing patterns.
supersetCanCSV property naming could be better · apache/superset#24290 | Good First Issue