apache/pinot

Fix logging dependencies in pinot-spi

Open

#6,364 创建于 2020年12月17日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (1,234 fork)batch import
good first issuehelp wanted

仓库指标

Star
 (4,937 star)
PR 合并指标
 (平均合并 6天 7小时) (30 天内合并 186 个 PR)

描述

pinot-spi’s pom has a dependency on log4j-slf4j-impl. I don’t think this is right - it should only depend on slf4j-api. Because of the current dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.

I'm guessing there are other components with a similar issue - only jars that are run from the command line should have dependencies on log4j-slf4j-impl, and include log4j2 configuration resources.

贡献者指南