"Too many concurrent requests in flight" error message is misleading
#4,798 创建于 2020年1月12日
仓库指标
- Star
- (6,777 star)
- PR 合并指标
- (平均合并 17小时 31分钟) (30 天内合并 3 个 PR)
描述
@ali-raza-tariq commented on Fri Jan 10 2020
The existing implementation shows the following error message when inflight limit is exceeded
<Response [429]> b'{\n "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'
Few suggestions:
The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)
So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)
Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)