apache/openwhisk

do not base64 encode __ow_body for raw web actions

Open

#3,920 创建于 2018年7月30日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Scala (6,777 star) (1,177 fork)batch import
controllergood first issuehelp wanted

描述

#3919 removes the base64 encoding requirement when returning JSON as string (and setting the content-type). However we continue to encode JSON for raw http actions receiving __ow_body. For symmetry, we should stop doing that as well. This is largely in place for legacy reasons (spray vs akka). The net of this change is that functions would JSON.parse(param.__ow_body) instead of JSON.parse(decode64(param.__ow_body)).

贡献者指南

技术栈
无
领域
backendcloud
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understand OpenWhisk action encodingFamiliarity with raw web actions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue references PR #3919 that removed base64 encoding for JSON responses. The goal is to similarly remove base64 encoding for raw web actions' ow body. Look at the code handling raw HTTP actions, likely in the same area as the previous change. The comment mentions spray vs akka legacy reasons, so the change might be in the routing or serialization layer. Search for 'base64' or 'decode64' in the codebase related to ` ow body`.