apache/openwhisk

WskRestOperation implements action create with copy but it should not

Open

#3,846 创建于 2018年7月6日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Scala (6,777 star) (1,177 fork)batch import
help wantedtesting

描述

The copy operation is a function of the cli, not the rest api. So supporting a copy in the WskRestOperation's implementation of wsk.action.create doesn't make sense.

https://github.com/apache/incubator-openwhisk/blob/3ab604c167ac5bec76c756e3e76473863eb0a25d/tests/src/test/scala/common/rest/WskRestOperations.scala#L332

The code should be removed and any rest tests in place should be moved strictly to the cli tests. It's arguable we should preserve this behavior --- if we reify this implementation into a scala SDK for openwhisk. Otherwise, I'm not sure why we should support this.

贡献者指南

技术栈
scala
领域
apicli
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Scala basicsUnderstanding of OpenWhisk CLI vs API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue points to a specific file: tests/src/test/scala/common/rest/WskRestOperations.scala. The task is to remove the copy operation from the `wsk.action.create` implementation in WskRestOperations and ensure that any REST tests using this feature are moved to CLI tests. First, examine the linked code to understand the current implementation. Then, remove the relevant code and check for any dependent tests. Finally, verify that all tests pass.