apache/incubator-seata

Is it necessary that both the RM client and the TM client start a timer for reconnecting to seata server ？

Open

#5,338 创建于 2023年2月13日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)Java (25,960 star) (8,878 fork)batch import
good first issue

描述

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

Is it necessary that both rm client and tm client start a timer for reconnecting to seata server？

The log of 2 timeoutCheckers is as follows： 2023-02-13 10:12:51.547 INFO 4079 --- [eoutChecker_1_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:12:51.917 INFO 4079 --- [eoutChecker_2_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:13:01.547 INFO 4079 --- [eoutChecker_1_1] i.s.d.r.k8s.K8sRegistryServiceImpl 2023-02-13 10:13:01.916 INFO 4079 --- [eoutChecker_2_1] i.s.d.r.k8s.K8sRegistryServiceImpl

io.seata.core.rpc.netty.AbstractNettyRemotingClient#init
public void init() {
        timerExecutor.scheduleAtFixedRate(new Runnable() {
            @Override
            public void run() {
                clientChannelManager.reconnect(getTransactionServiceGroup());
            }
        }, SCHEDULE_DELAY_MILLS, SCHEDULE_INTERVAL_MILLS, TimeUnit.MILLISECONDS);

贡献者指南

技术栈
java
领域
backenddatabase
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of Seata's architectureFamiliarity with Java and Netty
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate whether both RM client and TM client need separate reconnect timers. The issue points to `io.seata.core.rpc.netty.AbstractNettyRemotingClient#init` where a single timer is scheduled. Review the code to see if both clients share this class or have separate instances. Consider consolidating into one timer if appropriate, or document why two are needed. Check related comments in the issue for maintainer feedback.