apache/dubbo

[CodeReview 3.0] Dubbo in spring

Open

#8,633 创建于 2021年8月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Java (26,453 fork)batch import
help wanted

仓库指标

Star
 (41,524 star)
PR 合并指标
 (平均合并 7天 14小时) (30 天内合并 20 个 PR)

描述

1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar.

DubboConfigConfigurationRegistrar only has one function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);
}

but DubboComponentScanRegistrar also has this function call:

public void registerBeanDefinitions(AnnotationMetadata importingClassMetadata, BeanDefinitionRegistry registry) {
    // initialize dubbo beans
    DubboSpringInitializer.initialize(registry);

    Set<String> packagesToScan = getPackagesToScan(importingClassMetadata);

    registerServiceAnnotationPostProcessor(packagesToScan, registry);
}

贡献者指南