apache/brpc

Remove implementation specific function name of EventDispatcher

Open

#1,894 创建于 2022年8月17日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)C++ (16,226 star) (3,936 fork)batch import
good first issuerefactor

描述

Some of the member functions of EventDispatcher are implementation specific, for example AddEpollOut.

We need to change that specific function name and adopt more general name then we can easily support brpc to more platforms.

贡献者指南

技术栈
cpp
领域
backend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++ programmingEventDispatcher component
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the EventDispatcher class in the source code, likely in `src/brpc/event dispatcher.cpp`. Identify all occurrences of the function `AddEpollOut` and understand its platform specific context. Propose a generic name such as `AddPollableFd` or `AddEvent`, then rename the function and update all references. Check the issue comments for any prior discussion on naming conventions or preferred alternatives.