apache/beam

Extract common class for WithTimestamps.AddTimestampsDoFn and Create.TimestampedValues.ConvertTimestamps

开放

#18,350 创建于 2022年6月3日

 (0 条评论) (0 个反应) (0 位负责人)Java (4,097 个派生)batch import
P3coregood first issueimprovementjava

仓库指标

星标
 (7,313 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

It seems like these APIs are predominantly duplicative of each other and, that it's hard to find one of them if you knew about the other.

https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/WithTimestamps.java#L134

https://github.com/apache/beam/blob/348d335883b14a9b143b65e4b3c62dc79f62d77e/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Create.java#L560

What would make the most sense to me is if TimestampedValues were implemented in terms of both Values and WithTimestamps. I'm still learning about Beam though -- would this approach cause some kind of performance problem?

Imported from Jira BEAM-1811. Original Jira may contain additional context. Reported by: wtanaka.

贡献者指南