antonioru/beautiful-react-hooks

useDebouncedCallback doesn't consider its dependencies

Open

#420 创建于 2023年11月29日

在 GitHub 查看
 (3 评论) (2 反应) (0 负责人)JavaScript (7,095 star) (505 fork)batch import
buggood first issuehelp wanted

描述

Describe the bug

This is the same issue reported in #386 for useDebouncedCallback, I don't know why that issue has been closed. I'd expect that any dependency given as args will invalidate the callback but that's not the case because deps are not given to the useEffect call here. As result the callback sees the values as one step behind.

To Reproduce

Here's a codesandbox to reproduce the issue https://codesandbox.io/p/sandbox/pedantic-grass-f9f6qw

Expected behavior

When I click on useDebouncedCallback button I should see same values as other buttons in console, but I see the old counter value.

Screenshots

image

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
understanding of React hooksfamiliarity with useEffect dependencies
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The fix is in src/useDebouncedCallback.ts line 28, where the useEffect call is missing dependencies. Add the deps array to the useEffect dependency list. The issue also references #386 for similar fix in useDebouncedCallback. Check that file and the code sandbox for expected behavior. Ensure the debounced function updates when dependencies change.