ant-design/ant-design

Make font sizes based on rem instead of px (number) for theme

Open

#38,915 创建于 2022年11月23日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (98,031 star) (54,612 fork)batch import
Inactivehelp wanted

描述

What problem does this feature solve?

Font sizes are today marked as number type and therefore only px is allowed. If they can be made as string we could either pass a px or a rem or a pc as values to it

What does the proposed API look like?

fontSize*: string | undefined

贡献者指南

技术栈
typescriptreactcss
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
TypeScriptReactAnt Design theme system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Start in the theme token definition file, likely `components/theme/interface.ts` or similar, locate the `fontSize` token. Change its TypeScript type from `number` to `string | undefined`. Update any internal usage that relies on numbers for calculations. Ensure backward compatibility by handling string values like '16px' or '1rem'. Test with different font size values. Consult related PRs or comments for additional context.