ant-design/ant-design

Modal 下 destroyOnClose 属性 失效

Open

#28,847 创建于 2021年1月13日

在 GitHub 查看
 (5 评论) (2 反应) (0 负责人)TypeScript (98,031 star) (54,612 fork)batch import
Inactivehelp wanted🐛 Bug

描述

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://fvrw0.csb.app/

Steps to reproduce

modal下使用video标签，播放后，关闭modal video or audio标签依然播放， 且重新打开modal 依然存在

What is expected?

modal关闭后销毁媒体标签

What is actually happening?

modal关闭后未销毁标签

Environment Info
antd 4.10.2
React 16.12.0
System win10
Browser firefox

贡献者指南

技术栈
typescriptreacthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Reactantd Modal componentcomponent lifecycle
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue is that the Modal's destroyOnClose prop does not destroy media elements (like video) when the modal closes. Investigate the Modal component in the antd repository, likely in components/modal/Modal.tsx, to understand how destroyOnClose is implemented. Check if the issue is related to React's unmounting behavior or conditional rendering. The reproduction link shows the problem, so replicate it. Look at the component's state management and ensure that when destroyOnClose is true, the child components are properly unmounted (e.g., using a key prop or conditional rendering). Also check if there are any existing comments or maintainer responses that hint at a solution.