ansible/awx

Allow to add a new choice for a existing variable in custom credential type after it is already in use

Open

#8,792 创建于 2020年12月9日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (13,071 star) (3,333 fork)batch import
component:apihelp wantedtype:enhancement

描述

ISSUE TYPE
  • Feature Idea
SUMMARY

I made a form with choices in a custom credential type, this custom credential type is in use in a credential. if I modify a var name in the INJECTOR, it's fine, but if I want to add a choice for a var already existing I get an error message :

Modifications to inputs are not allowed for credential types that are in use

I could understand if I was trying to modify the field name, as the form is not the same that the one in use, but just adding a choice doesn't modify the fields or the number of fields, nothing really important in fact, but it is blocked

We can't delete all the credential using a credential type, if we just need to add a choice

贡献者指南

技术栈
pythondjangorest api
领域
backendapi
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of AWX credential typesFamiliarity with Django models
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is about a validation in the credential type model. Look at the model or serializer for CredentialType, specifically the logic that prevents modification of inputs when the credential type is in use. The current code likely compares the new inputs with old ones and rejects changes. To allow adding choices, you would need to modify the validation to permit additive changes to choices fields while still blocking other modifications. Check the file awx/api/serializers.py or awx/main/models/credential.py for the relevant validation.