angular/components

Overlay is not destroyed while navigating using Browser's Back/Forward button (RouteReuseStrategy is used)

Closed

#17,973 创建于 2019年12月16日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)TypeScript (6,650 fork)batch import
P3area: cdk/overlayhelp wanted

仓库指标

Star
 (24,044 star)
PR 合并指标
 (平均合并 2天 16小时) (30 天内合并 80 个 PR)

描述

Reproduction

https://angular-hlrhkp-pzxidw.stackblitz.io/

Steps to reproduce:

  1. Click on the navigate to second page link.
  2. Click on Browser Back Button and Open the select box .
  3. Click on the browser forward button to navigate.

Expected Behavior

What behavior were you expecting to see? The overlay of the previous component should be destroyed, when the browser navigation buttons clicked

Actual Behavior

What behavior did you actually see? The overlay of the material persists even after the page is routed to next page

Environment

  • Angular:
  • CDK/Material: 5.21
  • Browser(s): Chrome
  • Operating System (e.g. Windows, macOS, Ubuntu): Windows

贡献者指南

研究方向
Investigate how Angular CDK overlay's lifecycle interacts with router navigation when RouteReuseStrategy is used. Look at the overlay ref counting mechanism in the OverlayRef and how it handles detach on route change. Check if there is a missing cleanup when the route is reused. Consider examining the following files: overlay ref.ts, overlay container.ts, and the RouterModule setup.
技术栈
typescript
领域
frontend
议题类型
缺陷
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 天
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
较久未更新
清晰度议题是否清楚说明期望改动、验收标准和下一步。
清晰
前置要求
Angular basicsAngular CDK OverlayRouteReuseStrategy
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25