angular-ui/ui-grid

Column width by percentage does not account for selection column

Open

#6,093 创建于 2017年3月17日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Expected Behavior When defining columns with percentage widths, if the columns defined in gridOptions.columnDefs add up to a total of 100%, they will fill up and not overflow the grid viewport.

Actual Behavior If ui-grid-selection is being used, the columns will overflow the grid viewport by the width of the selection column.

The selection column is a part of the grid control itself and not the data display, as evidenced by not being defined in columnDefs, so its size should be accounted for when calculating the size of the viewport, much like the vertical scroll bar is.

This plunker illustrates the issue by defining one 100% width column in a selectable grid: http://plnkr.co/edit/BcV3qI64mMOnNMdDAjPM?p=preview

You will have to enter app.js and change enableRowHeaderSelection to false to see that the sizing is correct when the selection row header is removed, as indicated by the comment there. (I tried to wire up a button to do this, but couldn't get the grid to recognize the change.)

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of AngularFamiliarity with ui grid
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue is about the selection column width not being accounted for when calculating column widths using percentage values. The plunker at http://plnkr.co/edit/BcV3qI64mMOnNMdDAjPM?p=preview demonstrates the problem. Investigate the grid's column sizing logic, likely in the core grid files, to see how the selection column width is excluded from the total width calculation. The fix should ensure that the selection column's width is considered when distributing percentage based column widths, similar to how the vertical scroll bar is accounted for.