angular-ui/ui-grid

Removing a row when all are expanded, everything will collapse leaving the button as "-" (expanded)

Open

#6,032 创建于 2017年2月21日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

I have a grid with 2 levels with expandable options and delete rows for the first level grid. After delete any row, the data is reloaded, its ok if everything is collapsed, the issue is : the button is showing "-" instead of "+" Steps:

  1. Expand all rows image
  2. Delete 1 row image
  3. The grid is reloaded and the button is "-" image

Plunker: http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic familiarity with AngularJSUnderstanding of ui grid expand/collapse
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
The issue involves a state inconsistency when deleting a row after expanding all rows. Investigate the Plunker link (http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview) and the ui grid source code, particularly the expand/collapse toggle logic and the data reload mechanism after deletion. Look at how the grid resets the expand state when the data changes. The bug likely lies in the toggle state not being re evaluated after the grid data is refreshed.