angular-ui/ui-grid

Fixes issue of eventOrigin not getting passed to begin edit when edit mode is triggered by cellNav

Open

#5,799 创建于 2016年11月9日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Fixes an issue where when ALL FEATURES are applied to grid and enableCellEditOnFocus is set to true the edit event would not pass the event to the beginEdit method causing issues with custom editors that rely on the type of event that triggered the cell into edit mode.

Take a look at the comments in the ui-custom-editor.js file.

http://plnkr.co/edit/FCqb3G5I70hyE2JrPFhN?p=preview

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
AngularUI Grid custom editors
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is that eventOrigin is not passed to beginEdit when edit mode is triggered by cellNav. Look at the custom editor in ui custom editor.js, and the plnkr link: http://plnkr.co/edit/FCqb3G5I70hyE2JrPFhN?p=preview. The fix likely involves ensuring that the event object is correctly forwarded. Check how cellNav triggers edit and compare with other triggers.