angular-ui/ui-grid

saveState (in Demo) reselects incorrect rows after sorting (related to: #5663)

Open

#5,706 创建于 2016年9月29日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

To reproduce:

  1. go: http://ui-grid.info/docs/#/tutorial/208_save_state
  2. select first three rows
  3. click Save
  4. sort on first column
  5. click Restore

Result: the incorrect three rows are selected.

Observation: as noted in #5663, suspect the use of row indexes is the cause of this issue.

Further: With external pagination, selection or sorting this issue is compounded.

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate how row indexes are used in saveState and restoreState functions. The issue references #5663 which likely highlights similar problems with row indexes. Look into the demo code at the tutorial link and the ui grid source for state saving logic. A fix would involve using unique row identifiers instead of indexes.