angular-ui/ui-grid

Sorting is broken when grid is expanded. App is stuck!

Open

#5,562 创建于 2016年7月19日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Hi all,

We have been using ui-grid (http://ui-grid.info/docs/#/tutorial/216_expandable_grid) in our project and currently facing with the following issue. I understand that expandable feature is still in alpha release.

Issue: Sorting is broken when grid is expanded and the grid becomes non-responsible.

Here's the plunker for reference: http://plnkr.co/edit/JvCwjInAFlzKnhjs51FR?p=preview

Steps to reproduce:

  1. As soon as the grid is loaded, expand all elements by clicking on "Expand All" button or "+" icon.
  2. Start sorting by "Dateofservice" column (2nd column).
  3. Grid/app is frozen with the exception Uncaught Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!

Notes:

  1. When the grid is not expanded, sorting by all columns (including second column) is working without any issues.
  2. After all nested grids are expanded, if I start sorting by any other column except the 2nd column and sort by 2nd column next, no issues. Everything works fine.
  3. If I sort by 2nd column by expanding only one or two first nested grids, leaving all other grids in collapsed mode, sorting works without any problem.
  4. This could be a bug or data issue. To be consistent with the expandable tutorial we are using complex.json data structure and have added couple extra data.

Can you please take a look into this issue and let me know your thoughts and comments?

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
AngularJSui grid expandable featureJavaScript debugging$digest cycle understanding
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
15
研究方向
Examine the sorting implementation in ui grid's expandable feature, particularly the interaction between expandable rows and column sorting. Review the provided Plunker to reproduce the issue. Check the grid's internal digest cycle management to identify why sorting a specific column after expanding all rows causes infinite digests. Look at the sort logic in the source code (likely in src/features/expandable/ or similar) and compare with the working case of sorting when not expanded. Consider if the issue arises from watch expressions or data changes triggered by expanding rows.