angular-ui/ui-grid

saveState's restoreColumn unnecessarily calls for the pinning of columns/refresh of grid

已关闭

#5,314 创建于 2016年4月12日

 (0 条评论) (0 个反应) (0 位负责人)JavaScript (2,496 个派生)batch import
good first issue

仓库指标

星标
 (5,395 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

restoreColumn's unnecessarily calls for pinning a column/refreshing the grid when a column is currently not pinned and the saved state is also not pinned.

When a column's pinned state is saved, if the column.renderContainer is null, it saves it as an empty string: savedColumn.pinned = column.renderContainer ? column.renderContainer : '';

However, inside the if statement to determine if a pinned column should change, it performs the check: currentCol.renderContainer !== columnState.pinned

Because the column.renderContainer gets stored as an empty string instead of null when being saved, I think the same logic to replace renderContainer with an empty string should also be performed when restoring the columns to prevent an unnecessary pinning/refresh.

贡献者指南