angular-ui/ui-grid

saveState's restoreColumn unnecessarily calls for the pinning of columns/refresh of grid

Open

#5,314 创建于 2016年4月12日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

restoreColumn's unnecessarily calls for pinning a column/refreshing the grid when a column is currently not pinned and the saved state is also not pinned.

When a column's pinned state is saved, if the column.renderContainer is null, it saves it as an empty string: savedColumn.pinned = column.renderContainer ? column.renderContainer : '';

However, inside the if statement to determine if a pinned column should change, it performs the check: currentCol.renderContainer !== columnState.pinned

Because the column.renderContainer gets stored as an empty string instead of null when being saved, I think the same logic to replace renderContainer with an empty string should also be performed when restoring the columns to prevent an unnecessary pinning/refresh.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of AngularJSFamiliarity with ui grid saveState feature
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue describes a comparison mismatch when restoring column pinned state. Investigate the saveState.js file, specifically the restoreColumn function around line 595. Check how pinned state is saved (line 381) where `column.renderContainer` is replaced with an empty string if null. The restore comparison `currentCol.renderContainer !== columnState.pinned` fails when both are null vs empty string. The fix likely involves normalizing the comparison or handling null/empty equivalently. There are no comments or PRs to reference, so the solution should be implemented based on the described behavior.