angular-ui/ui-grid

Grouppriority default treeAggregationFn overwrite bug

Open

#5,123 创建于 2016年2月16日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (2,496 fork)batch import
good first issuegrid-grouping

仓库指标

Star
 (5,395 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

According to the docs the groupingColumnBuilder function should get one of the default aggregations when the groupPriority is undefined or less then 0, however, in the code it does otherwise:

If the groupPriority is undefined or less than 0, then we expect to be aggregating, and we look at the aggregation types to determine what sort of aggregation we can do. Values are in the constants file, but include SUM, COUNT, MAX, MIN

if ( typeof(col.grouping.groupPriority) !== 'undefined' && col.grouping.groupPriority > -1 ){
    col.treeAggregationFn = uiGridTreeBaseService.nativeAggregations()[uiGridGroupingConstants.aggregation.COUNT].aggregationFn;
    col.treeAggregationFinalizerFn = service.groupedFinalizerFn;
}

As you see in the above code, it actually checks for !== 'undefined' && > -1, which overwrites a possible custom set treeAggregationFn with a default one.

This above code is taken from the current release, line #18959

贡献者指南