angular-ui/ui-grid

autoAdjustHeight - expose on api?

Open

#4,831 创建于 2015年12月9日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

I need to adjust the height of the grid based on the number of rows in my datasource. For example, set the height of the grid to the actual number of rows if less than 10, otherwise only show 10 and have the vertical scrollbar.

This behavior is easily accomplished using the minRowsToShow property. However, the grid doesn't respond to changes to the property after it is initialized.

Inside the compile function, autoAdjustHeight is called. I have fixed this by adding the autoAdjustHeight to the public api. Then I can call autoAdjustHeight when my datasource changes and I've updated the minRowstoShow property.

Is there a better way to accomplish this? Or should I submit a pull request with this api change?

贡献者指南

技术栈
javascript
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Locate the compile function in the ui grid source code where autoAdjustHeight is called. Examine the public API object to add the autoAdjustHeight method. Check if any recent changes have addressed this or if there is an alternative approach. Consider submitting a pull request with the API change.