angular-ui/ui-grid

Adding a row changes the selected cell with ui-grid-cellNav

Open

#4,738 创建于 2015年11月20日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issuegrid-cellNavhelp wantedtype: bug

描述

Hi,

I've spotted a bug when I use ui-grid-cellNav and try to add a new element to the data. This bug only happens when the new element is added on top of the grid, and when it's done, the class "ui-grid-cell-focus" doesn't move with its matching cell and thus highlights the wrong element.

Check this plnkr : http://plnkr.co/edit/MFywMvsLDRvK8PMq1I6m It's already sorted by ID.

  1. Select "Bender Jefferson" cell
  2. Click Add row - it will duplicated the first entry
  3. The class "ui-grid-cell-focus" remained on the same cell so its now highlighting the wrong element.
  4. Click on "Get current focused cell" and check that thw row number doesn't match.

贡献者指南

技术栈
javascripthtml
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic AngularJSui grid concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
The issue is reproducible in the provided Plnkr (http://plnkr.co/edit/MFywMvsLDRvK8PMq1I6m). Steps: select a cell, click 'Add row' which duplicates the first entry, then the focus class remains on the old cell. The bug only occurs when the new element is added on top of the grid. Investigate the cellNav directive's handling of focus on row add, likely in the source files related to cell navigation (e.g., 'ui grid/cellnav.js'). Check if the focus index is recalculated properly when rows are inserted at the beginning. Also examine related issues or PRs that may have addressed similar problems.