angular-ui/ui-grid

When explicit row height set, mouse wheel scroll doesnt work.

Open

#4,351 创建于 2015年9月10日

在 GitHub 查看
 (0 评论) (0 反应) (1 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issuegrid-core

描述

putting an int value in rowHeight produces strange results, I've been using pixel value as rowHeight: '200px'. It looks like getCanvasHeight expects integer value there though so doesnt do anything to see the px value. This causes bad values coming from that function but doing this fixes it:

change:

self.visibleRowCache.forEach(function(row){
  self.$$canvasHeight += row.height;
});

to:

self.visibleRowCache.forEach(function(row){
  self.$$canvasHeight += parseInt(row.height.replace("px", ""));
});

贡献者指南

技术栈
angularjavascriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScriptAngular
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug is in the code that sums visibleRowCache heights. The fix is to change the line `self.$$canvasHeight += row.height;` to parse integer from `row.height` by removing 'px' suffix. The relevant file is likely in the ui grid source, possibly in the grid rendering module. Review the function that sets row height and the mouse wheel scroll handler to ensure consistency.