angular-ui/ui-grid

Tooltips take the cell's filter even when not needed

Open

#4,302 创建于 2015年9月1日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
help wanted

描述

Hi, I've tried to setup a cell tooltip for a filtered cell.
I've followed the code in ui-grid and found some issues (https://github.com/angular-ui/ui-grid/blob/fcbafc6c3594be9aa75fa35d69b9bf01bf3925cd/src/js/core/services/gridClassFactory.js#L114).

I have 2 cases in which this is a problem:

  1. I want to filter the cell content, and in a tooltip show the unfiltered content.
  2. I want to enact a different filter on the tooltip (or enact the filter in the tooltip's function).

These 2 use cases are very close to each other and there are several variants I can think of for each.

I've implemented my solution in my app: Set a tooltipFilter property in the colDef that would either be unedfined (to use the cell's filter), a string/function that returns a string (for a filter) or false (for no filter).

What do you think? Is there a better way to do this?

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
AngularJS basicsui grid cell templates
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the current tooltip implementation in ui grid, particularly in gridClassFactory.js around line 114 where cell filters are applied. The issue proposes adding a `tooltipFilter` property to colDef. Review the comments for additional context. Implement the property to allow false, a string filter name, or a function, ensuring backward compatibility.