angular-ui/ui-grid

grid.selection.selectedCount not refresh on clearSelectedRows()

Open

#4,300 创建于 2015年9月1日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Almost everything is in the title : when the function clearSelectedRows() is called, the property grid.selection.selectedCount is not reset to 0. So the count is not right, and when you select rows again, the former count is increased. So you can have 23 selected rows on a grid which contains only 20 elements. I'm using version 3.0.0-rc20. Please let me know if this issue has been fixed on a more recent version.

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of AngularFamiliarity with ui grid selection API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Investigate the `clearSelectedRows()` function in the selection feature module of ui grid. The `selectedCount` property likely needs to be reset to 0 within that function. Check the source code in `src/features/selection/` or similar directories. Existing comments may indicate similar issues or patches. The fix is likely a one line change to reset the count.