angular-ui/ui-grid

height calculation error produces extra white space below the last row, with option enableFiltering: true

Open

#4,275 创建于 2015年8月26日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

Here is my plunker: http://plnkr.co/edit/WYZUxZHFGpa3RCaAyJDy?p=preview

When enableFiltering: true, the height calculation is wrong.

In this particular case, changing the grid height to 181px works, that's 4px off. I am thinking I need to hard override the grid height as a workaround.

贡献者指南

技术栈
javascriptangularhtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Angular basicsUI Grid codebase structureCSS box modelJavaScript debugging
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the grid height calculation logic in the ui grid source code, particularly the functions that compute total height based on row heights and enableFiltering. Review the plunker to reproduce the issue. Look for any CSS or JavaScript that adds extra space when the filter row is enabled. Check if there are any existing PRs or comments that address similar height issues.