angular-ui/ui-grid

Pagination includes sub grid in page size

Open

#4,168 创建于 2015年8月12日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issueneeds: analysis

描述

Hi,

If I select the Page size to display, let's say 5 records, and I have 5 records, each with 2 sub Items, it will display only 3 items on the first level....so it is counting the sub Items in the pagination...not sure if this is the intent, or if it can be set...pls c pic below: image

贡献者指南

技术栈
angularjavascripthtmlcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of ui grid tree grid conceptsBasic Angular knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The bug is that pagination counts sub grid rows as part of the page size, causing fewer top level rows to display. To fix, locate the pagination logic in the ui grid source code, likely in the pagination service or directive. Examine how the total number of rows is computed when tree grid is enabled. Ensure that only top level rows are considered for pagination, not expanded sub rows. The screenshot shows an example with 5 records each having 2 sub items, resulting in only 3 top level items displayed when page size is 5. Check GitHub code at https://github.com/angular ui/ui grid, focusing on files like 'gridRowBuilder.js' or 'pagination.js'.