angular-ui/ui-grid

3.0.0-RC.20 row header got focused when tab off the previous row

Open

#3,389 创建于 2015年4月30日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

image

When tab off the last cell of previous row, the focus is on the row header since RC. 20. I changed the function setTabEnabled() { $elm.find('div').attr("tabindex", -1); } to be function setTabEnabled() { $elm.find('div').attr("tabindex", 0); }

Then it correctly focused on the first cell but not row header.

Is this designed on purpose?

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
AngularJS basicsDOM tabindexUI Grid keyboard navigation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the setTabEnabled function to understand why tabbing from the last cell of a row causes focus to move to the row header instead of the first cell of the next row. The user's workaround suggests changing tabindex from 1 to 0 on div elements, but this may have side effects. Review the grid's keyboard navigation logic and check for any design decisions regarding row header focus. Examine the issue's reproduction and consider if this is a regression. See the original issue for details.