angular-ui/ui-grid

Sorting works inconsistently , when table column contains null/undefined/empty values

Open

#3,360 创建于 2015年4月24日

在 GitHub 查看
 (15 评论) (1 反应) (1 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

I observed that the handlenulls method present in all sort methods(exmaple : alphasort) is working inconsistently. It is unable to handle the empty values in present in the table while sorting. Note - I am using Sort Ascending and Sort Descending options and not the header options.

Scenario - When a column containing null values is sorted -

  1. Step 1 : Ascending order - null values are pushed at the bottom, values gets sorted correctly
  2. Step 2 : Descending order - nothing happens ,sorting does not work.

贡献者指南

技术栈
javascriptangular
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Examine the sorting methods in ui grid source, particularly the 'handlenulls' function within alphasort. Reproduce the bug with null values. Investigate why descending order does not work. Check comments in the issue for any hints. Propose a fix that handles null consistently for both ascending and descending order.