angular-ui/ui-grid

1px padding-top on ui-grid-canvas

Open

#3,275 创建于 2015年4月14日

在 GitHub 查看
 (4 评论) (0 反应) (1 负责人)JavaScript (5,395 star) (2,496 fork)batch import
good first issue

描述

1px padding was added to the top of the ui-grid-cavas in https://github.com/angular-ui/ng-grid/commit/040a5ee1acc1fdeda6a466fbe05d242f8775ef18. When you scroll the grids viewport to the top there is a 1px gap between the headers and the start of the grids rows.

It's not very noticeable with the grids default styles but if you change them, specifically if you make the cell borders a dark colour, the gap is very apparent.

贡献者指南

技术栈
javascriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSSHTML
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue is caused by a 1px padding top added in commit 040a5ee1. The fix likely involves removing or adjusting that padding. Examine the ui grid canvas CSS class in the source code. Ensure that removing the padding does not cause other visual regressions, especially with scrolling behavior.