angular-fullstack/generator-angular-fullstack

Enhancement: Remove serve-favicon dependency

Open

#2,640 创建于 2017年9月28日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (6,134 star) (1,268 fork)batch import
Help Wantedchoreenhancement

描述

The philosophy behind the serve-favicon module is rather outdated, almost nobody knows or cares about creating .ico files. Everyone just puts .png or .gif files now (Mac and iOS ignore .ico anyway). But omitting the favicon.ico file makes the app crash in production environment because of the serve-favicon dependency.

Please consider removing this module and adding support for the modern icons required by the newer OSs, by adding these lines in _index.html:

  <link rel="icon" type="image/png" href="/favicon.png">
  <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png">
  <link rel="icon" type="image/png" sizes="96x96" href="/favicon-96x96.png">
  <link rel="apple-touch-icon" href="/favicon_120_retina.png">
  <link rel="apple-touch-icon" sizes="152x152" href="/favicon_152_retina.png">
  <link rel="apple-touch-icon" sizes="167x167" href="/favicon_167.png">
  <link rel="apple-touch-icon" sizes="180x180" href="/favicon_180.png">

贡献者指南

技术栈
javascriptnodejsexpressangularhtmlcss
领域
frontendbackend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic HTML knowledgeNode.js project structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
90
研究方向
The issue requires removing the serve favicon dependency from the project's package.json and updating the index.html to include the provided favicon link tags. The file index.html is likely in the app's template directory. No linked PRs or comments indicate any ongoing work. The main task is to update the template and configuration.