angular-fullstack/generator-angular-fullstack

Should client/app/admin and account be full components?

Open

#2,490 创建于 2017年2月4日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (6,134 star) (1,268 fork)batch import
Help Wanted

描述

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.2
Node 6.9.4
npm 4.1.2
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize 4.0.0-2 / PostgreSQL 9.6.1
Auth Y

account(auth) and admin(auth) are implemented as loosely coupled controllers. Their implementation differs from the generated main component (which is an AngularJS component). Also, possibly change their controllerAs to $ctrl from vm.

What are your thoughts about making admin, login, settings, and signup into full AngularJS components? This would improve consistency as well as lay the foundation for those moving to 2.0.

贡献者指南

技术栈
javascriptangularnodejsexpresspostgresql
领域
frontenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
AngularJS component basicsYeoman generator structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Review the current implementation of admin, login, settings, and signup controllers in the templates/app/client/app/account(auth)/ and admin(auth)/ directories. Compare with the main component example at templates/app/client/app/main/main.component.js. Plan to refactor each controller into a full AngularJS component with its own template and controllerAs '$ctrl'. Ensure consistency with the main component structure.