angular-fullstack/generator-angular-fullstack

Should encryption and hashing functions be converted to be asynchronous?

Open

#2,240 创建于 2016年9月17日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)JavaScript (6,134 star) (1,268 fork)batch import
Help Wantedenhancement

描述

I noticed the use of the crypto library implements synchronous operations. Should this be dropped for use of asynchronous? Under heavy server load this could lock up the application right?

贡献者指南

技术栈
javascriptnodejs
领域
backendperformance
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Node.jsasync/await
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the use of synchronous crypto functions in the generator's codebase. Look for `crypto.createHash` or similar calls in files that handle encryption or hashing. Propose replacing them with asynchronous counterparts using `crypto.promisify` or `require('crypto').async`. Ensure the change does not break existing functionality and consider that the generator may run synchronously during generation, so evaluate if async is feasible. Check if there are existing PRs or maintainer comments on this topic.