angular-fullstack/generator-angular-fullstack

Error with PUT with Sequelize Backend

Open

#2,180 创建于 2016年8月26日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (6,134 star) (1,268 fork)batch import
Help WantedV4bug

描述

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.0.1
Node 4.4.5
npm 3.10.5
Operating System OS X 10
Item Answer
Transpiler Babel
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB SQL
Auth N

Hey,

It appears the Mocha PUT tests / Upsert Functionality for the Sequelize backend are broken.

The test expects the object back when according to the Sequelize documentation it only return a true or a false. http://docs.sequelizejs.com/en/latest/api/model/#upsertvalues-options-promisecreated

Although in my case I get undefined... which causes it to not return anything and breaks the backend route entirely. I think it might be because I'm using Postgres... I was able to modify the backend code fine to get around it. but figured I should raise it anyways.

贡献者指南

技术栈
javascriptnodejsexpresssql
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Sequelize basicsMocha testingExpress route handlingUnderstanding of PUT endpoints
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Examine the test file for PUT endpoint (likely 'server/api/thing/thing.spec.js') and the corresponding route handler. The issue reports that the test expects an object from Sequelize's upsert, but it returns true/false. Search the codebase for the upsert call and test expectations. Refer to issue comments for additional context. Modify the test to expect a boolean or adjust the route to return the correct value.